Gowin. Add I3C io buffer. #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A buffer is added that can operate as a normal IOBUF in PUSH-PULL mode or switch to open-drain IOBUF mode. Signed-off-by: YRabbit <[email protected]>
gatecat
reviewed
Jan 29, 2025
himbaechel/uarch/gowin/gowin.h
Outdated
| @@ -106,6 +110,7 @@ NPNR_PACKED_STRUCT(struct Tile_extra_data_POD { | |||
| int32_t class_id; | |||
| int16_t io16_x_off; | |||
| int16_t io16_y_off; | |||
| int32_t i3c_capable; | |||
There was a problem hiding this comment.
are there likely to be other flags like this you want to store here? instead of using a whole int32_t for this, what about an int32_t flags field with one bit for this and the rest reserved for future, similar, tile flags
Signed-off-by: YRabbit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A buffer is added that can operate as a normal IOBUF in PUSH-PULL mode or switch to open-drain IOBUF mode.